fix(mint): fix pruning panic, add developer and community funding #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We configure "utsp" via manual genesis.json editing. The migration still writes "utsp" because it's fixing our bad behavior (we should've edited the genesis).
gsora
changed the title
utsp mint denom, fix pruning panic
noandrea
reviewed
Jun 30, 2022
* fix: disable CGO for node builds * feat(devnet): adding script to spin up local devnet (#160) * feat(mint): distribute developer and community funds This commit enables distribution of 2*10% off the newly-minted tokens to the x/distribution community pool, and the developer funding pool. The developer funding pool is represented as a standard Cosmos address, which should be determined at genesis time. Co-authored-by: Andrea Giacobino <no.andrea@gmail.com> Co-authored-by: PaddyMc <paddymchale@hotmail.com>
gsora
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much what the title says.
Before running this PR:
1151280v1.0.0-rc2with pruning in any mode exceptnothing(we wanna have pruning!)testnetUpgrade20220706must be created and approvedThe fix for the pruning issue has been taken from cosmos/ibc-go#1088.
Please, review the issue as well as this PR before giving a ✅!
Thanks <3
PSA
This PR previously hardcoded
utspas the defaultMintDenomfor thex/mintmodule params, but after a conversation with @noandrea we decided it's best we leave it assdk.DefaultBondDenom, and let the chain admin set denoms viagenesis.jsonediting.The 2022-07-06 migration will still set
MintDenomtoutsp, but we do that to try having a working SDK migration in place.#167 will take care of generalizing tests instead of testing for "stake" everywhere, so this PR must be merged first.
Edit
#167 has been approved and merged here instead, so this PR now enables developer and community funding as well.